Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DRAFT: ✨ Signed-Release: Add check for sigstore signatures #1846

Closed
wants to merge 1 commit into from
Closed

DRAFT: ✨ Signed-Release: Add check for sigstore signatures #1846

wants to merge 1 commit into from

Conversation

asraa
Copy link
Contributor

@asraa asraa commented Apr 18, 2022 •
edited
Loading

Signed-off-by: Asra Ali [email protected]

What kind of change does this PR introduce?

(Is it a bug fix, feature, docs update, something else?)

What is the current behavior?

Signed-Release checks for presence of signature file extensions

What is the new behavior (if this is a feature change)?**

Signed-Release also checks for rekor entries to detect signatures uploaded on transparency log

  • Tests for the changes have been added (for bug fixes/features)
    TODO

Which issue(s) this PR fixes

#1201

Special notes for your reviewer

Does this PR introduce a user-facing change?

For user-facing changes, please add a concise, human-readable release note to
the release-note

(In particular, describe what changes users might need to make in their
application as a result of this pull request.)



RESULTS
-------
Aggregate score: 10.0 / 10

Check scores:
|---------|-----------------|--------------------------------|-----------------------------------------------------------------------|----------------------------------------------------------------------------|
|  SCORE  |      NAME       |             REASON             |                                DETAILS                                |                         DOCUMENTATION/REMEDIATION                          |
|---------|-----------------|--------------------------------|-----------------------------------------------------------------------|----------------------------------------------------------------------------|
| 10 / 10 | Signed-Releases | 5 out of 5 artifacts are       | Debug: GitHub release found: v1.7.2 Info: signed                      | https://github.com/ossf/scorecard/blob/main/docs/checks.md#signed-releases |
|         |                 | signed, 1 artifacts are        | release artifact: cosign-1.7.2.aarch64.rpm-keyless.sig:               |                                                                            |
|         |                 | sigstore signed -- score       | https://api.github.com/repos/sigstore/cosign/releases/assets/62331947 |                                                                            |
|         |                 | normalized to 10               | Debug: GitHub release found: v1.7.1 Info: signed                      |                                                                            |
|         |                 |                                | release artifact: cosign-darwin-amd64-keyless.sig:                    |                                                                            |
|         |                 |                                | https://api.github.com/repos/sigstore/cosign/releases/assets/61634977 |                                                                            |
|         |                 |                                | Debug: GitHub release found: v1.6.0 Info: signed                      |                                                                            |
|         |                 |                                | release artifact: cosign-1.6.0.aarch64.rpm-keyless.sig:               |                                                                            |
|         |                 |                                | https://api.github.com/repos/sigstore/cosign/releases/assets/58527521 |                                                                            |
|         |                 |                                | Debug: GitHub release found: v1.5.2 Info: signed                      |                                                                            |
|         |                 |                                | release artifact: cosign-darwin-amd64-keyless.sig:                    |                                                                            |
|         |                 |                                | https://api.github.com/repos/sigstore/cosign/releases/assets/57296270 |                                                                            |
|         |                 |                                | Debug: GitHub release found: v1.5.1 Info: signed                      |                                                                            |
|         |                 |                                | release artifact: cosign-darwin-amd64-keyless.sig:                    |                                                                            |
|         |                 |                                | https://api.github.com/repos/sigstore/cosign/releases/assets/55449328 |                                                                            |
|---------|-----------------|--------------------------------|-----------------------------------------------------------------------|----------------------------------------------------------------------------|

Currently I'm only checking the latest release. It seems to take a while to download the release asset in order to compute it's hash. Any suggestions?

naveensrinivasan
naveensrinivasan reviewed Apr 18, 2022
View reviewed changes
Copy link
Member

@naveensrinivasan naveensrinivasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Can you please include the unit test and e2e?

@asraa
Copy link
Contributor Author

asraa commented Apr 18, 2022

Thanks! Can you please include the unit test and e2e?

Yes, this is a TODO per the description (this is why it's a draft, haven't written up the check YAML yet either).

I am mostly putting this out for discussion. It makes the check fairly slow to download the release artifact.

Perhaps we guard with an env variable?

@naveensrinivasan
Copy link
Member

Thanks! Can you please include the unit test and e2e?

Yes, this is a TODO per the description (this is why it's a draft, haven't written up the check YAML yet either).

I am mostly putting this out for discussion. It makes the check fairly slow to download the release artifact.

Perhaps we guard with an env variable?

Apologies didn't see the Draft in the title. Usually, draft PR's come as draft PR.

@github-actions
Copy link

Stale pull request message

@github-actions github-actions bot closed this May 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@naveensrinivasan naveensrinivasan naveensrinivasan left review comments

@azeemshaikh38 azeemshaikh38 Awaiting requested review from azeemshaikh38

@justaugustus justaugustus Awaiting requested review from justaugustus

@laurentsimon laurentsimon Awaiting requested review from laurentsimon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@asraa @naveensrinivasan